Some things I noticed when testing the menu changes:
If I use the DCERPC RTT statistics and ask for statistics for SPOOLSS,
the resulting statistics window is taller than my display.
Perhaps the container for those widgets needs to be made scrollable.
Would it make more sense to make the actual table of values a GtkCList,
with the column headings being the titles? You could make the columns
sortable by doing that, for example.
Also, should the table omit procedures for which there are no calls?
In addition, would it make sense to, for example, split taps such as
that one into:
common code that constructs a table data structure with title
lines, column head text, and multiple column values;
Tethereal UI code that prints out the title lines, column
heads, and column values;
Ethereal UI code that puts up a widget with the title lines and
a GtkClist (or whatever) with the column heads and column
values?
The first of those would be tap-specific, but the latter two would be
routines that could be used by any tap.
In order to handle the SMB RTT tap, it'd have to support *multiple*
tables per tap.
That way:
a lot of the code in various taps could be shared by all those
taps;
the code that goes through the packets and computes the
statistics could perhaps also be shared by all those taps;
it might be possible to share enough other UI code so that a tap
such as that might have *no* GUI code whatsoever - it might be
able to share all the GUI code;
it might be possible to transparently allow other presentations
of those statistics, such as graphical presentations.