Ethereal-dev: Re: [Ethereal-dev] Patch: RFC 3514 support

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 31 Mar 2003 22:09:27 -0800
On Tue, Apr 01, 2003 at 01:10:37AM -0500, dheitmueller wrote:
> Looks fine.  Except the argument to localtime() needs to be &now, and
> not &tmp.

Right.  Oops.

> Should we be checking for timezone? Otherwise I would be five
> hours off because I'm on Eastern US time and localtime() returns GMT.

"localtime()" returns the local time value, which is presumably what
would govern the interpretation of the bit.

> Also, on Win32, we may wish to use _localtime64(), so we can handle up
> to December 31, 3000 UTC.  I'd hate to commit a change, and have
> everything break in 2038.

Yup.  Hopefully, on UNIX, by that time we'll have 64-bit time_t on all
platforms.