[Guy Harris <guy@xxxxxxxxxx>]

On Sun, Feb 23, 2003 at 08:16:37PM +1000, Wayne Parrott wrote:
> I have been playing around with ethereal and come up with a patch to
> decode the latest version of the yahoo messenger protocol. It's pretty
> basic at the moment, it just decodes the headers and splits the data
> into key and values.

I've checked it in...

> Let me know if you have any problems or see any places for improvement.

...with changes to address Joerg's comments:

> 1) Please do not create a separate .h file that is only included in one
>    .c file - just insert the code into the .c file directly.

I also pulled packet-yhoo.h into packet-yhoo.c.

> 2) Do not use c++ (c99) style comments (//), use old style comments
>    instead.

I fixed one comment, and just got rid of the other commented-out code -
it would be a Very Bad Idea for the YMSG dissector to register on ports
23 and 25, as those are *supposed* to be used for Telnet and SMTP, and,
given that the YHOO and YMSG protocols both use port 5050, we really
can't registere either of them on port 5050, either.

> 3) Add your dissector to Makefile.nmake too.

I did that.

> 4) Add the references for the protocol (URLs) if available to the
>    comments at the beginning of the file.

I found some URLs with Google and put them in.