Ethereal-dev: Re: [Ethereal-dev] Modification to packet-tns.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 3 Feb 2003 15:53:30 -0800
On Mon, Feb 03, 2003 at 01:50:25PM -0800, David M. Lee wrote:
> So, would a call to tvb_length_remaining be more appropriate?  Or at least
> safer in the presence of maliciously short packets?  Or would something else
> be better?

I'm not sure what the right answer would be (and I'm not taking
ownership of the issue, so discussion should continue on ethereal-dev).

> Otherwise, does the code look sane?  I couldn't find anything resembling a
> developer's guide, so I'm afraid that the code is mostly cut and
> paste.

>From a brief look at it, it looked mostly sane.  I haven't had time to
look at it in detail.