Ethereal-dev: Re: [Ethereal-dev] Ethereal 0.9.7 dumps core in packet-smb-pipe.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxx>
Date: Thu, 14 Nov 2002 11:18:22 -0800
On Thu, Nov 14, 2002 at 12:07:37PM +0100, Milos Urbanek wrote:
> Quick hack of packet-smb-pipe.c gets the solution by replacing:

Having worked around the bug so that Ethereal doesn't crash, you can now
look at the capture again to see why it is that "trp->param_descrip" was
null in the call to "dissect_response_parameters()".

It appears that this would happen only if the request corresponding to
the reply whose dissection caused the crash were short (captured with a
short snapshot length, or not reassembled), so that the descriptor
string wasn't present; was that the case?

If so, the correct fix is not to call "dissect_response_parameters()"
if "trp->param_descrip" is null.