Checked in.
The patch did not apply cleanly so i ended up applying it manually.
No worries.
I assume you did not yet add the conversation stuff to register the protocol
based on traffic seen discussed earlier on the list?
Two cosmetic suggestions:
There are a few places where a bitmask is dissected using
proto_tree_add_text() in the tree. These places should be changed to use
proto_tree_add_boolean().
See packet-smb.c or any other dissector on how FT_BOOLEAN types are used.
In the definition for the hf_index array, the last string element "" before
the HFILL
parameter is a description blurb, i.e. what text is displayed to explain the
field
in the bottom right textbox when the field is selected.
A good dissector becomes even better if this text is filled in.
If you think it is worth it and want to, please consider adding some
description text to these fields.
best regards
ronnie sahlberg
(as for all other aussies on the list, two weeks from now im having a big
house warming party
up towards central coast. if you are in the region you are invited to come
by and help me drink all the beer.)
----- Original Message -----
From: "Brad Hards"
Sent: Wednesday, October 02, 2002 5:50 PM
Subject: Re: [Ethereal-dev] SLPv2 support
> The attached patch (which obsoletes my badly named -30oct02 version :)
adds
> SLPv2 support (RFC2608) to the existing SLPv1 support. The only change
> between this and my last patch is the removal of the text markers, which
> weren't doing anything meaningful.