Ethereal-dev: Re: [Ethereal-dev] SLPv2 support

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
From: Brad Hards <bhards@xxxxxxxxxxxxxx>
Date: Tue, 1 Oct 2002 07:16:42 +1000
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 1 Oct 2002 00:16, Ronnie Sahlberg wrote:

> See the changes to packet-portmap.c between version 1.35 and 1.36   I think
> it is reasonably similar to what you are after.
> (When portmap sees certain packets it will register a dissector for that
> port.)
> So, inside the dissector for the RQ,E1 -> x,SLP packet, you just create a
> conversation
> for RQ,E1 <-> ANY,ANY   and attach your dissector to it.
Thanks. I'll take a look. I guess I'd need to find something that deregisters 
too (based on time or packet behaviour).

> There is the switch(function) thingy where inside each case: x
> there is a proto_tree_add_text() to put the name of the function in the
> tree.
> Is this not redundant and really the same as the previous
> proto_tree_add_uint(srvloc_tree, hf_srvloc_function,
> earlier in the same function?
It is a bit redundant. I would have killed it, except that it acts as a marker 
between the common parts and the function-specific parts of the packet.
I'll look again. Maybe it would look better as a sub-tree....

If I clean this up, is there any chance of getting it applied to CVS?

Brad
- -- 
http://conf.linux.org.au. 22-25Jan2003. Perth, Aust. Tickets booked.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9mL87W6pHgIdAuOMRAkgDAJ45hotvHxlfsoVbiai+zSn7IAtguACgieTF
mLMoSI0x9TowbyML2TgTYt8=
=5R/X
-----END PGP SIGNATURE-----