Ethereal-dev: Re: [Ethereal-dev] Patch for an enhanced progress bar dialog box

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 28 Aug 2002 03:12:25 -0700
On Wed, Aug 28, 2002 at 01:24:57AM +0200, Ulf Lamping wrote:
> Attached is a medium sized patch, which will extend the existing
> progress dialog box. 

Checked in (with some warnings cleaned up).

> The dialog box is looking fine on my windows machine, but I'm really
> not the GTK guru.

It looks OK on FreeBSD as well.

It might be useful to have "create_progress_dlg()" and
"delayed_create_progress_dlg()" take, as an argument, a format string to
use for the "XXX of XXX" indicator, and to have "update_progress_dlg()"
take, as arguments, two "long"s that are the current and final position,
rather than taking the progress value, and have it compute the progress
value and generate the status string itself, rather than requiring its
callers to do so.  ("read_cap_file()" would have to do that anyway, to
correctly handle reading from a file that's being written to, but the
stuff that scans an already-read capture wouldn't have to.)