Ethereal-dev: [Ethereal-dev] Bug in GTP decoding code in Ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Flavio Poletti (TEI)" <Flavio.Poletti@xxxxxxxxxxxxxxx>
Date: Fri, 23 Aug 2002 20:10:41 +0200
Hi,

	I've found a bug in the decoding of GTP v1 packets; maximum uplink bit rate and maximum downlink bit rate are swapped (rif. 3GPP TS 24.008, §10.5.6.5, using v.3.7.0).

The following is the output of diff after having corrected the bug in file "packet-gtp.c" (revision "1.32", tagged "release-0-9-6, HEAD", "MAIN" branch, ):

---------- cut here -----------------
3399,3400c3399,3400
<               max_dl = tvb_get_guint8(tvb, offset+6);
<               max_ul = tvb_get_guint8(tvb, offset+7);
---
>               max_ul = tvb_get_guint8(tvb, offset+6);
>               max_dl = tvb_get_guint8(tvb, offset+7);
---------- cut here -----------------

I think (and hope!) this is the only point in the file in which such a swap occurred, but I have no time to recompile all :) However, in the lines following the error it seems that the developer correctly uses offset 6 for uplink.

Hope this can help, best regards,

	Flavio.


PS: I've not subscribed to the mailing list, if you want to investigate further please write directly to me.

--
Security Class: Open