Ethereal-dev: Re: [Ethereal-dev] [patch] packet-fw1.c FW1 monitor dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 8 Aug 2002 02:36:50 -0700
On Tue, Aug 06, 2002 at 08:52:03PM +0200, Alfred Koebler wrote:
> here is the actual patch with additional comments.

Checked in, but without the "capture_fw1()" routine (it was unused, and
as libpcap doesn't supply FW1 monitor file data and there's no DLT_
value for FW1 monitor files, it's not going to be used), and with
"dissect_fw1()" made static, so that the "packet-fw1.h" file wasn't
necessary and wasn't added.

Also:

> To start ethereal with interpretation of FW1 monitor file:
>   ethereal -o eth.eth_interpret_as_fw_monitor:TRUE -r FILE

I got rid of the "eth_" in "eth_interpret_as_fw_monitor" - the full name
is "eth.interpret_as_fw_monitor", so another "eth_" isn't necessary -
and got rid of the extra "fw1_" in the FW1 dissector's preference as
well.  (Yes, there are some other preferences with an extra copy of the
preference name - those are errors as well, although cleaning those up
would involve adding support for "aliases" for preferences, so that the
old names would be mapped to the new names in preference files.)