Ethereal-dev: [Ethereal-dev] [PATCH] rate_graph

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Francesco Fondelli <f.fondelli@xxxxxx>
Date: Mon, 24 Jun 2002 13:14:09 +0200
Hi, and sorry for my silence,


------------------------------------------------------------------
On Tue, 18 Jun 2002 13:50:21 +0200
in message 20020618115021.GA32454@xxxxxxxxxxxx
Pavel Mores <pvl@xxxxx> wrote:
> [cut]
>- please release a standard diff so that we can do something like
>"patch -p1 <rate_graph.diff" as usually.

put rate_graph.[ch] in the gtk dir and apply the patch




On Tue, 18 Jun 2002 22:37:14 +1000
in message 003101c216c4$e03695f0$0901010a@C5043436
"Ronnie Sahlberg" <sahlberg@xxxxxxxxxxxxxxxx> wrote:
> Hi,
> VERY nice screenshots. Well done!!!

thanks 
 
> Four comments:
> 1,  You should put your name at the top of the file for bragging rights.

done

> 2,  Can you convert all C++ comments into C comments. Ethereal is supported
> on platforms/compilers which does not allow C++ comments.

done

> [cut] 
> 4,  (could you also translate the comments into english? it would make it
> easier for Swedes like
> me to understand it)

sorry, done





On Tue, 18 Jun 2002 21:25:01 -0700
in message 20020618212501.A333@xxxxxxxxxxxxxxxxxxx
Guy Harris <gharris@xxxxxxxxx> wrote:

> It might be useful to put numbers on the horizontal axis (presumably
> each tick is 1 second, but numbers might be useful), and numbers on the
> vertical axis other than the maximum value.

horizontal done 


----------------------------------------------------------------------


I'm happy for your interest but I think that my code is still instable and 
immature to be checked in now. I hope for some gtk programmers check the source 
to fix bugs and unnecessary code. In the next week I'll try to add some 
basic improvements.


Best Regards
FF

Attachment: rate_graph.patch
Description: Binary data

Attachment: rate_graph.c
Description: Binary data

Attachment: rate_graph.h
Description: Binary data