Ethereal-dev: Re: [Ethereal-dev] PATCH: new filters button

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 22 Jun 2002 13:02:51 -0700
On Sat, Jun 22, 2002 at 02:06:36PM -0400, Devin Heitmueller wrote:
> Here is a minor tweak

...which was "helpfully" line-wrapped by some piece of mail software, so
I had to apply the change by hand; a *lot* of either mail transfer
agents or mail user agents appear to "helpfully" line-wrap text or
convert tabs to spaces in text, which really screws up patches in the
bodies of mail messages.

If you send patches as attachments, rather than as part of the body of
the messate, they appear to be less likely to be "improved" by mail
software.

> to give the user some feedback when using the
> filter interface.  In the current model, if the user clicks the "new"
> button and the filter fields are empty, nothing happens.  This can be
> really confusing to users new to Ethereal.  Now we give them an error
> message telling them that the two fields need to be completed in order
> to create the filter.

Checked in (with some changes to the message it displays).