Ethereal-dev: Re: [Ethereal-dev] MAPI

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Thu, 23 May 2002 16:48:52 -0700
On Thu, May 23, 2002 at 06:52:09PM -0400, Todd Sabin wrote:
> p.s.  attached is a skeleton for the NSPI interface, which often
> accompanies MAPI stuff.

Checked in.

> p.p.s.  This is really just a nitpick, but does it make sense to have
> separate .h files for dcerpc subdissectors?  Currently, the only thing
> in them is #defines which are used in exactly one place (the
> dcerpc_sub_dissector struct).  And it's hard to see where else they'd
> be used.  I'd just as soon see the raw number, myself.  Anyway, not a
> big deal...

I don't put stuff in .h files unless it's used in more than one source
file.  I could see wanting the #define names, though.

BTW:

>  * $Id: $

I think that should be just

	 * $Id$

for the initial checkin.

> #include "packet.h"

That should be

	#include <epan/packet.h>

in recent Ethereal source trees.