Ethereal-dev: Re: [Ethereal-dev] unused variables in packet-dcerpc-XXX.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Frank Singleton <frank.singleton@xxxxxxxxxxxx>
Date: Mon, 06 May 2002 08:14:20 -0500
Guy Harris wrote:

> 
> It's used by code in the first of two assignments to the
> "template_main_dissector_switch_msgtype_end" variable.  However, unless
> there's some Python subtlety I'm not seeing, that variable is never
> *used*.
> 
> If so, then
> 
>         1) both assignments to that variable should presumably be
>            removed;
> 
>         2) the definition of "offset_saved" should presumably be removed
>            as well, as "ethereal_gen.py" no longer generates any code
>            that refers to it.
> 
> Frank, is that the case?

Yes and yes. It was planned (and I may still resurrect it one day)
to restore offset if I get a parsing error, so I could take some
other actions . However, that is a little way off, so references to 
"offset_saved" can be yanked for now.

Sorry, a little busy to make a patch at the moment.

-- 

Cheers / Frank

--

EUS/WV/Z Frank Singleton      ASO Americas BSS
Office : +1 972 583 3251      ECN 800 33251  
Mobile : +1 214 228 0874      Amateur Radio: VK3FCS/KM5WS   
Email : frank.singleton@xxxxxxxxxxxx

Hardware: HP Omnibook 4150 running Redhat Linux 7.1 (2.4.3-12 kernel).