Ethereal-dev: [Ethereal-dev] small dcerpc fixes

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Thu, 2 May 2002 23:41:02 +0200
see changelog
--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.
Changelog: <jmayer@xxxxxxxxx>
	- packet-dcerpc.c: flag some unused variables as such and
	    remove the remaining ones (as proposed by Ronnie Sahlberg)
	- packet-dcerpc-epm.c: remove unused variable dummy

Index: ethereal/packet-dcerpc.c
===================================================================
RCS file: /cvsroot/ethereal/packet-dcerpc.c,v
retrieving revision 1.46
diff -u -r1.46 packet-dcerpc.c
--- packet-dcerpc.c	2002/04/30 01:43:12	1.46
+++ packet-dcerpc.c	2002/05/02 21:23:39
@@ -369,7 +369,7 @@
  */
 
 int
-dissect_dcerpc_uint8 (tvbuff_t *tvb, gint offset, packet_info *pinfo,
+dissect_dcerpc_uint8 (tvbuff_t *tvb, gint offset, packet_info *pinfo _U_,
                       proto_tree *tree, char *drep, 
                       int hfindex, guint8 *pdata)
 {
@@ -385,7 +385,7 @@
 }
 
 int
-dissect_dcerpc_uint16 (tvbuff_t *tvb, gint offset, packet_info *pinfo,
+dissect_dcerpc_uint16 (tvbuff_t *tvb, gint offset, packet_info *pinfo _U_,
                        proto_tree *tree, char *drep, 
                        int hfindex, guint16 *pdata)
 {
@@ -404,7 +404,7 @@
 }
 
 int
-dissect_dcerpc_uint32 (tvbuff_t *tvb, gint offset, packet_info *pinfo,
+dissect_dcerpc_uint32 (tvbuff_t *tvb, gint offset, packet_info *pinfo _U_,
                        proto_tree *tree, char *drep, 
                        int hfindex, guint32 *pdata)
 {
@@ -423,7 +423,7 @@
 }
 
 int
-dissect_dcerpc_uint64 (tvbuff_t *tvb, gint offset, packet_info *pinfo,
+dissect_dcerpc_uint64 (tvbuff_t *tvb, gint offset, packet_info *pinfo _U_,
                        proto_tree *tree, char *drep, 
                        int hfindex, unsigned char *pdata)
 {
@@ -596,7 +596,7 @@
 }
 
 static int
-dissect_deferred_pointers(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset, char *drep)
+dissect_deferred_pointers(packet_info *pinfo, tvbuff_t *tvb, int offset, char *drep)
 {
 	int found_new_pointer;
 	dcerpc_info *di;
@@ -894,7 +894,7 @@
 	   argument */
 	if(pointers_are_top_level==TRUE){
 		pointers_are_top_level=FALSE;
-		offset = dissect_deferred_pointers(pinfo, tree, tvb, offset, drep);
+		offset = dissect_deferred_pointers(pinfo, tvb, offset, drep);
 		pointers_are_top_level=TRUE;
 	}
 
@@ -1793,7 +1793,7 @@
 }
 
 static void
-dissect_dcerpc_dg_auth (tvbuff_t *tvb, packet_info *pinfo, proto_tree *dcerpc_tree,
+dissect_dcerpc_dg_auth (tvbuff_t *tvb, proto_tree *dcerpc_tree,
                         e_dce_dg_common_hdr_t *hdr, int *auth_level_p)
 {
     int offset;
@@ -2012,7 +2012,7 @@
          * DCE_C_AUTHN_LEVEL_PKT_PRIVACY, we can't dissect the
          * stub data.
          */
-        dissect_dcerpc_dg_auth (tvb, pinfo, dcerpc_tree, &hdr, NULL);
+        dissect_dcerpc_dg_auth (tvb, dcerpc_tree, &hdr, NULL);
     }
     /* 
      * keeping track of the conversation shouldn't really be necessary
Index: ethereal/packet-dcerpc-epm.c
===================================================================
RCS file: /cvsroot/ethereal/packet-dcerpc-epm.c,v
retrieving revision 1.6
diff -u -r1.6 packet-dcerpc-epm.c
--- packet-dcerpc-epm.c	2002/04/29 09:41:45	1.6
+++ packet-dcerpc-epm.c	2002/05/02 21:23:39
@@ -103,8 +103,6 @@
                              packet_info *pinfo, proto_tree *tree, 
                              char *drep)
 {
-    guint32 dummy;
-
     offset = dissect_ndr_ctx_hnd (tvb, offset, pinfo, tree, drep,
                                   hf_epm_lookup_hnd, NULL);