Ethereal-dev: Re: [Ethereal-dev] Warning fixes (unused params)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: David Frascone <dave@xxxxxxxxxxxx>
Date: Thu, 2 May 2002 08:02:38 -0500
On Thursday, 02 May 2002, Guy Harris wrote:
> On Wed, May 01, 2002 at 01:44:45PM +0200, Joerg Mayer wrote:
> > This patch removes the "small offenders".
> 
> Checked in, except for:
> 
> 	packet-diameter.c, as I'd like David Frascone to say whether the
> 	arguments should be removed or not (silence means consent, but
> 	requires a timeout so it's not preferred).

I looked at the changes.  They look fine.

But, I do have a question.  I just set the makefile to do -Wall, and I
receive no warnings.  Are you guys turning on extra warnings?  Looking at
gcc's man page -Wall is supposed to include -Wparameter . . . strange.

Compile line, which generated no warnings:
gcc -DHAVE_CONFIG_H -I. -I. -I.   -I. -I./wiretap -I/usr/local/include  -DINET6 -D_U_="__attribute__((unused))" -Wall -g -O2 -I. -I./wiretap -I/usr/local/include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include -c packet-diameter.c


-- 
David Frascone

      A Shower is the halfway point between Bed and World.