Ethereal-dev: Re: [Ethereal-dev] Removed unused parameters from packet-icq.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 1 May 2002 18:48:34 +0200
On Wed, May 01, 2002 at 06:31:31PM +0200, Joerg Mayer wrote:
> 	Remove all unused parameters from packet-icq.c

Just looking into packet-icq.c again, it looks like there are lots of
functions doing 

type function(params, tree) {
  declarations;
  if (tree) {
  ...
  }
}

Would it be Ok to do the check for tree once in dissect_icq and remove it
from all other functions?

  Ciao
        Jï¿œrg

--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.