[Tim Potter <tpot@xxxxxxxxx>]

On Mon, Apr 22, 2002 at 02:34:19AM -0700, Guy Harris wrote:

> On Wed, Apr 17, 2002 at 06:17:45AM -0500, Tim Potter wrote:
> > tpot        2002/04/17 06:17:44 CDT
> > 
> >   Modified files:
> >     .                    packet-dcerpc-samr.c 
> >   Log:
> >   Prettification of SAMR dissector - display short names in COL_INFO.
> 
> Is there some reason why, for example, the entry in the
> "dcerpc_samr_dissectors[]" table for "Open User" message has "OPEN_USER"
> as the name, but the dissectors for the request and response use
> "OpenUser" as the name when they put the name in COL_INFO?
> 
> I.e., why more than one name?

I think it was mainly historical.  The original dissectors didn't have
access to the opnum table or couldn't find out what the opnum for the
function currently being dissected.  Either that or I didn't know how to
access that information.

> And if there's a reason why there should be more than one name, why
> doesn't a "dcerpc_sub_dissector" structure have both names in it, so the
> DCE RPC dissector can put the short name into COL_INFO for you, rather
> than requiring dissectors to do it themselves?

Ah, now that was because I thought the rqst FOO_BAR(...) format put in
the COL_INFO format was ugly.  (-:  If we use one of the structures we
now have stored in the private_data this can be cleaned up.


Tim.