Ethereal-dev: RE: [Ethereal-dev] Help please - CVS ethereal blows up everytime

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Tom Uijldert <Tom.Uijldert@xxxxxx>
Date: Wed, 10 Apr 2002 11:02:22 +0200
> -----Original Message-----
> From: Guy Harris [mailto:gharris@xxxxxxxxx]
> Sent: Thursday, April 04, 2002 12:16 PM
> To: Mark Burton
> Cc: ethereal-dev@xxxxxxxxxxxx
> Subject: Re: [Ethereal-dev] Help please - CVS ethereal blows up
> everytime
> 
> 
[SNIP]
> If it does, fix that dissector not to use the return value of an
> "proto_tree_add_" routine as a "proto_tree *"; yes, "proto_tree" and
> "proto_item" happen to be typedeffed to the same value, but 
> that doesn't
> mean they're the same sort of item - dissectors should assign an ett_
> value to all subtrees, and use "proto_item_add_subtree()" to convert a
> "proto_item *" to a "proto_tree *".

Attached a fix for the same on UCP.
This crashed on an old trace (so it never used to...), what exactly changed?

Regards,
Tom Uijldert          Email: Tom.Uijldert@xxxxxx

Attachment: packet-ucp.c.diff
Description: Binary data