Ethereal-dev: [Ethereal-dev] Unused function parameters: Request for help

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Sat, 30 Mar 2002 16:33:44 +0100
Hello,

a while ago I submitted some patches to turn on additional warnings with
gcc. Due to the amount of addional warnings that are generated in the main
directory (dissectors), I added the flag -Wno-unused to that Makefile. I've
included a count of unused function parameters per file. If everyone
could take a look at their pet dissectors and add a _U_ to those
unused parameters that can't be avoided and remove the others, this would
help me a lot. I will start removing the remaining warnings after a 0.9.4
release, but that will a) take time and b) may be against what the maintainer
had in mind for this code.
What you need to do is remove the option -Wno-unused from the top level
Makefile (or the plugin Makefile) or, for the more curious from the top
level configure.in and rebuild the dissector you want to fix.

  Thanks
             Jï¿œrg

Dissectors and plugins:
     12	packet-afs.c
      2	packet-atalk.c
      1	packet-atm.c
      3	packet-beep.c
      1	packet-clnp.c
     34	packet-coseventcomm.c
     15	packet-cosnaming.c
      1	packet-data.c
     16	packet-dcerpc-lsa.c
      7	packet-dcerpc-netlogon.c
     12	packet-dcerpc-nt.c
      4	packet-dcerpc-samr.c
     76	packet-dcerpc-spoolss.c
      6	packet-dcerpc.c
      3	packet-diameter.c
      1	packet-dvmrp.c
      2	packet-eigrp.c
      1	packet-esis.c
     20	packet-giop.c
     72	packet-gryphon.c
     52	packet-gtp.c
      2	packet-hclnfsd.c
     14	packet-icq.c
      3	packet-igmp.c
      6	packet-ip.c
      1	packet-ipp.c
      2	packet-ipv6.c
      3	packet-ipx.c
     13	packet-isakmp.c
      4	packet-isis-clv.c
     17	packet-isis-hello.c
     24	packet-isis-lsp.c
      2	packet-isis-snp.c
      1	packet-isis.c
     48	packet-isup.c
      2	packet-kerberos.c
      1	packet-ldp.c
      1	packet-m3ua.c
      4	packet-mgcp.c
      1	packet-mip.c
     15	packet-msproxy.c
      1	packet-nbns.c
      2	packet-ncp2222.inc
     65	packet-ndmp.c
      7	packet-netbios.c
     52	packet-nfs.c
      3	packet-nisplus.c
      3	packet-nlm.c
      2	packet-osi-options.c
      4	packet-portmap.c
     36	packet-ppp.c
      1	packet-pppoe.c
     15	packet-pptp.c
      1	packet-q2931.c
      8	packet-quake.c
      2	packet-quake2.c
      1	packet-quake3.c
      1	packet-quakeworld.c
      2	packet-ranap.c
      5	packet-rpc.c
      6	packet-rtcp.c
      1	packet-rx.c
      1	packet-sccp.c
     46	packet-scsi.c
     45	packet-sctp.c
     13	packet-sdp.c
      1	packet-sip.c
      2	packet-smb-browse.c
      3	packet-smb-common.c
      3	packet-smb-logon.c
     58	packet-smb-pipe.c
    125	packet-smb.c
      2	packet-snmp.c
      3	packet-socks.c
      9	packet-ssl.c
      1	packet-stat.c
      2	packet-tcp.c
      1	packet-v120.c
      3	packet-vines.c
      4	packet-wcp.c
      6	packet-wsp.c
      2	packet-x11.c
      1	packet-ypserv.c
Main programs, tools and libs:
      7	capture.c
      2	capture_stop_conditions.c
      2	colors.c
      1	conditions.c
      2	dfilter_expr_dlg.c
      1	editcap.c
      4	grammar.c
      2	lemon.c
      1	mergecap.c
      2	pcap-util.c
      1	prefs.c
      1	print.c
      1	proto_dlg.c
      5	proto_draw.c
      1	proto_hier_stats.c
      1	reassemble.c
      1	ringbuffer.c
      2	tethereal.c
      1	xdlc.c
--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.