[Adam <adam@xxxxxxxxxxxx>]

> > 	this is experiemental patch to add defragmentation support to
> > 	EAP/EAP-TLS layer.

> It appears to reassemble data from multiple frames; you might want to
> put a list of frames into the protocol tree, as is done for other forms
> of multi-frame reassembley (see the "IP Fragments" entry for frame 2,
> for example).

I have added this.
>
> You also might want to mark the TLS data in all but the last frame as
> fragments, and show it only in the final frame; seeing the same data in
> multiple frames makes it look, at least to me, as if *both* frames
> contained that data, i.e. that data was transmitted twice.  (Yes, we
> show it for all frames for IP reassembly; I'm not sure that's a good
> idea, either.  We don't do that for TCP reassembly.)

Dunno. I like it this way.

This or other way. How about the patch now?
Can it make into the tree before 0.9.3 comes out?

	http://www.eax.com/patches/ETHEREAL/ethereal-eaptls-defrag-2-diff

Here's same data (same old data):

	http://www.eax.com/patches/ETHEREAL/packets/eap-tls.fragment.dump


-- 
Adam
http://www.eax.com	The Supreme Headquarters of the 32 bit registers