Ethereal-dev: Re: [Ethereal-dev] VMS parser patch to handle fragmented packets

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Marc Milgram <mmilgram@xxxxxxxxxxxx>
Date: 25 Mar 2002 16:08:56 -0500
TCPIPTRACE_FRAGMENTS_HAVE_HEADER_LINE comments out code that would work
if TCPtrace worked the way I expect it to.  At the start of every packet
is a line of the following form:

   TCPIPtrace XMT packet 16 at 14-NOV-2001 16:34:33.16

In fragmented packets, that line only appears with the first fragment.

I added the #ifdef because this situation might change, and it would be
nice to use a stricter rule for where a packet starts.

On the other hand, I suspect that people will be running current
versions of TCPtrace for several more years.

So, you are welcome to remove the unused code along with the comment
that references TCPIPTRACE_FRAGMENTS_HAVE_HEADER_LINE.

-Marc Milgram

On Mon, 2002-03-25 at 15:55, Guy Harris wrote:
> On Mon, Mar 25, 2002 at 03:46:00PM -0500, Marc Milgram wrote:
> > +#ifdef TCPIPTRACE_FRAGMENTS_HAVE_HEADER_LINE
> 
> So is the stuff with TCPIPTRACE_FRAGMENTS_HAVE_HEADER_LINE around it
> experimental code?  If not, note that #ifdefs for configuration options
> are a bit of a pain, as
> 
> 	1) they don't work with binary releases
> 
> and
> 
> 	2) they're even a pain with source releases unless you have a
> 	   configuration-script "--enable" option for them.