Ethereal-dev: Re: [Ethereal-dev] Two patches, packet-q931 and packet-tpkt

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 25 Mar 2002 12:19:32 -0800
On Mon, Mar 25, 2002 at 09:50:11AM +0100, andreas.sikkema@xxxxxxxxxxx wrote:
> 2. packet-tpkt.c If packet-tpkt is used to dissect fragmented tcp packets,
>    and is allowed to really dissect the frame, this patch will clear the
>    summary info, so dissectors called by dissect_tpkt can append
>    info to the column. without the column being polluted by "unnecessary"
>    information

Checked in.

> The patch for packet-tpkt might need a little more work but I don't have
> any other captures including TPKT use to verify this feeling.

A couple of questions:

	1) What if you *haven't* enabled desegmentation in TPKT? 
	   Wouldn't there still be an issue with the subdissector
	   appending stuff?

	2) In the second part of the patch, why the test of
	   "pinfo->fragmented"?

(Much of the problem here is due to having only a single row in the
packet-list pane for a frame, even if there's more than one higher-level
PDU in a frame, thus obliging subdissectors to append stuff if they
want information about all of the frames in the Info column.)