Ethereal-dev: Re: [Ethereal-dev] more leap stuff

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Adam <adam@xxxxxxxxxxxx>
Date: Tue, 19 Mar 2002 06:57:42 -0500 (EST)
> On Tue, Mar 19, 2002 at 03:48:23AM -0500, Adam wrote:
> > basically defines all known EAP types
>
> Checked in, along with changes to use "tvb_bytes_to_str()", rather than
> "tvb_format_text()", to display binary data such as challenges and
> responses.

ah, cool. I had been wondering for a while what's name for the function.

although I see you also changed the 'default' case to use bytes2str
instead for format_text. as well. This might or might not be a good idea.
For example EAP_TYPE_ID was done under default case, and argument for
EAP_TYPE_ID is just string with name.

One soultion would be to revert 'default' case to use format_text,
and the other would be to add another case for EAP_TYPE_ID and make
it use string. The later being probably better.

-- 
Adam
http://www.eax.com	The Supreme Headquarters of the 32 bit registers