Ethereal-dev: [Ethereal-dev] Bug in packet-smb-common.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date: Thu, 7 Mar 2002 15:54:34 +0100
Hi,

While trying out Ethereal 0.9.2 on a "real" network, I encountered an Application Error
(this is of course Win32). The error occurs in display_unicode_string() on line 68, I
think the function receives a non null terminated string and because the Temp buffer
is only 100 bytes long and the length of this buffer is not checked we have a buffer
overflow.

I suppose adding a check for the number of bytes that have been copied to the
temp buffer would be in order.

--
Andreas Sikkema
andreas.sikkema@xxxxxxxxxxx
"While you're waiting, read the free novel we sent you.
 It's a Spanish story about a guy named `Manual'" - Dilbert