Ethereal-dev: [Ethereal-dev] ringbuffer limits...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Neulinger, Nathan" <nneul@xxxxxxx>
Date: Fri, 8 Feb 2002 15:52:36 -0600
We had a small discussion about this a while ago, but never applied any
patch...

I have this ugly hack in my local checkout:

Index: ringbuffer.h
===================================================================
RCS file: /cvsroot/ethereal/ringbuffer.h,v
retrieving revision 1.1
diff -u -r1.1 ringbuffer.h
--- ringbuffer.h        2001/12/04 08:45:04     1.1
+++ ringbuffer.h        2002/02/08 21:49:44
@@ -33,7 +33,7 @@
 /* minimum number of ringbuffer files */
 #define RINGBUFFER_MIN_NUM_FILES 2 
 /* maximum number of ringbuffer files */
-#define RINGBUFFER_MAX_NUM_FILES MIN(10,FOPEN_MAX) 
+#define RINGBUFFER_MAX_NUM_FILES 2000
 
 int ringbuf_init(const char *capture_name, guint num_files);
 wtap_dumper* ringbuf_init_wtap_dump_fdopen(int filetype, int linktype,


but something better should ideally be used... Perhaps something using
sysconf, or just hardwire something seemingly reasonably like 1024. (If
the user tries to exceed it, who cares, it'll error out.)

I'd like to see something applied though, cause right now on the linux
boxes, it arbitrarily limits max_num_files to 10 (FOPEN_MAX is 16 I
think). Either 10 or 16 would both be nuts when I the actual limit is
1024 on my box by default. 

-- Nathan

------------------------------------------------------------
Nathan Neulinger                       EMail:  nneul@xxxxxxx
University of Missouri - Rolla         Phone: (573) 341-4841
Computing Services                       Fax: (573) 341-4216