Ethereal-dev: [Ethereal-dev] [patch] fix for dissect_nt_sid

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Tim Potter <tpot@xxxxxxxxx>
Date: Fri, 25 Jan 2002 13:47:57 +1100
Hi everyone.  Here is a small patch to do with NT SID dissection:

	- pretty up dissector output by removing duplicate text in
	  the NT SID subtree, and remove leading zeros from the
	  authority list

	- SID string prefixed with "S-1-"

	- the alignment should preceed the SID rather than come after
	  it based on the NDR alignment rules (look at a SAM LOGON
	  REQUEST packet which was dissected incorrectly)

	- add a header to packet-smb-common.h to fix compiler warning

I've tested this with the SAM LOGON REQUEST (just sniff a NT domain
logon to generate these) and some random captures that do security
descriptor queries (smb.cmd == 0xa0).  It looks much nicer now.  (-:


Tim.