Ethereal-dev: RE: [Ethereal-dev] Match selected from packet list & Prepare line

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Richard Urwin <RUrwin@xxxxxxxxxxxxxxx>
Date: Thu, 3 Jan 2002 15:45:56 -0000
>   I made simple imlementation of 6. point from Wish list - Filter
> generation from packet list. On right button on packet list is now 
> 'Match Selected' and 'Prepare' menus. It will add correct expression for 
> pointed (not selected!) packet and it's column to filter or prepare 
> line. 

Sounds good

>   There is new prepare line. There you can prepare filter expression 
> from filter dialog, showed packets, ... Then 'Use' button will apply 
> expression as active filter. 'Clear' button clears prepared expression. 
> There are two 'Filter' buttons. 

This seems to be rather complex. Could I suggest making the two right-click
menu items "AND to filter" and "OR to filter" If I understand you correctly
this would remove the need for the "prepare" line.

In the rare cases that you wanted a more complex behavior you could use
either of those and then cut-and-paste within the "filter" line.

If the filter is empty then both "AND to filter" and "OR to filter" should
do the same thing.

NB.
a)  I'm going by your description, I don't have diff installed on my winNT
machine.
b)  These are only my opinions, I'm nobody important.

-- 
Richard Urwin, Software Design Engineer
Ricardo Test Automation
Braemar Court, 1311b Melton Road, Syston, UK.
rurwin@xxxxxxxxxxxxxxx