Ethereal-dev: Re: [Ethereal-dev] Tiny onc-rpc patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Fri, 28 Dec 2001 12:19:52 -0800
On Fri, Dec 28, 2001 at 08:12:44PM +1100, Ronnie Sahlberg wrote:
> attached is a tiny tiny patch that is very useful.
> the patch adds an extra field to onc-rpc replies which displays the time
> between the reply packet and the corresponding
> request packet.

Checked in.

> something weird with filtering on FT_RELATIVE_TIME though.
> the most intuitive use, such as 'rpc.time>0.1' does not work the way one
> might suspect.
> this is very confusing since the display is often 'Time from request:
> 0.14xxxx seconds'
> this is very unintuitive. perhaps a bug? dont know since I havent looked at
> the code for FT_RELATIVE_TIME yet.

It appears that the code to convert a string to an FT_RELATIVE_TIME time
value is wrong - it converted "0.02" to 0 seconds, 2 nanoseconds, which
is obviously incorrect.

I'll look at fixing that.