Ethereal-dev: Re: [Ethereal-dev] First version of LSA pipe dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Tim Potter <tpot@xxxxxxxxx>
Date: Tue, 18 Dec 2001 08:54:39 +1100
On Mon, Dec 17, 2001 at 12:33:32AM -0800, Guy Harris wrote:

> On Mon, Dec 17, 2001 at 09:05:29AM +0900, Motonori Shindo wrote:
> > MSVC++ doesn't like the goto statement in this code for some
> > reason.

> I'll add another item to the "how to write more portable code" bit in
> "README.developer" about this.

Good idea.  It will save me falling into that trap again.  (-:

> However, I think it's a bit cleaner if we just get rid of the gotos
> entirely, so that's what I checked in.

I think the opposite - I tend to use gotos to avoid too much indentation
in a function, especially when there is cleanup code that needs to be
run.  Anyway, it doesn't really matter.

Regards,


Tim.