Ethereal-dev: Re: [Ethereal-dev] TDS decoding

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 21 Nov 2001 14:26:27 -0800 (PST)
> What is the  process to get these included in the tree?  

You make the source available (which you've already done), and tell us
whether you want us to check it in now or wait for others to test it.

> Let me know if you want diffs against CVS, but the changes to register.c 
> are rather trivial.

"register.c" isn't part of the Ethereal source - it's a generated file.

The changes that are more interesting are those to "Makefile.am" and
"Makefile.nmake"; you just add the source file for a dissector to the
"DISSECTOR_SRC" macros in both files (the macros in both files should be
identical), and add any header files to the "noinst_HEADERS" macro in
"Makefile.am".  (Adding the source to "Makefile.am" only isn't
sufficient, as you need to make it buildable on Windows with Microsoft
Visual C++ as well.)

Those changes are trivial, so we can make them, but it's generally
appreciated if patches include changes to "Makefile.am" and
"Makefile.nmake" as well.