Ok,
sorry.
What I meant was, if possible, hold back any mega-size multi-thousand-lines
patches for packet-smb-pipe.c packet-smb-mailslot.c etc
for a few days. I plan to change the interface slightly when I mail the last
transaction patch
(use separate tvuffs for setup/parameters/data)
Small patches of less than a few houndred lines would not make any
difference at all for me since it is already a bitch to update
my diff of a diff to match current CVS.
However, if you have already finished the patches, not much I can do then
:-(
best regards
ronnie sahlberg
To the wishlist (if anyone is maintaining it)
packet-rpc.c: make the "This is a response to the command in frame xxx"
into a display filter. and not just text.
Also, since state is already maintained to match request/response, add
timestamps to when the request was seen
so that the response can have something like
"Response was seen x.yyy seconds after the request". Should be
filterable.
----- Original Message -----
From: "Tim Potter" <tpot@xxxxxxxxx>
To: "Ronnie Sahlberg" <rsahlber@xxxxxxxxxxxxxx>
Cc: <ethereal-dev@xxxxxxxxxxxx>
Sent: Sunday, November 11, 2001 3:29 PM
Subject: Re: [Ethereal-dev] packet-smb big patch
> On Sun, Nov 11, 2001 at 03:04:39PM +1100, Ronnie Sahlberg wrote:
>
> > The future looks great for the cifs dissector, now with discussions of
> > adding DCE-RPC as well.
> > Cool.
> >
> > If possible, Please do not include any DCE-RPC patches in the next few
days.
> > I still have one semi-large patch for
> > packet-smb/transaction which will mess with the other smb dissectors as
well
> > (pipe/browse etc)
>
> The dce/rpc changes I just posted are a total of maybe 5 lines to both
> packet-smb-pipe.c and packet-dcerpc.c so they shouldn't get in the
> way of what you have been doing.
>
>
> Tim.
>