On Thursday, 01 Nov 2001, Guy Harris wrote:
> I've checked those files, and most of your most recent patch (except for
> the patch to "packet-diameter.c", obviously, as the message to which
> this is a reply had "packet-diameter.c" in it), and most of the files
> from an earlier message (except for "xmlstub.[ch]", obviously, as those
> were also in the message to which I replied).
right.
> I also updated "packaging/nsis/ethereal.nsi.in" to install
> "dictionary.dtd", "dictionary.xml", "mobileipv4.xml", "nasreq.xml", and
> "sunping.xml" into the main installation directory for Ethereal. I
> think NSIS may let us make the installation of that stuff optional; I've
> left it as mandatory for now.
They're relatively small. I'd say install them by default. Libxml2 is
larger, so I understand not shipping/installing that :)
The diameter dissector will print a warning (once per execution, not per
packet) if it can not find libxml2, or can not find the dictionary.
> We might want to update "rpm/ethereal.spec" for those files as well; I'm
> not sufficiently familiar with RPM to know what the right thing to do
> there is. I infer, perhaps incorrectly, that we'd add
>
> cp {file name} $RPM_BUILD_ROOT/etc
>
> lines for each of the files, and also add
>
> /etc/{file name}
>
> lines to the %config subsection of the %files section, along the lines
> of what's done for the "manuf" file. (I'm also inferring that %config
> is a section; if not, we'd presumably add a bunch of
>
> %config {file name}
>
> lines.)
I've only made one RPM, but that sounds about right. (Assuming, of course,
that get_datadir_thingie() will end up pointing to RPM_BUILD_ROOT/etc)
>
> We may want to update various bits of documentation to reflect the new
> XML-based dictionary, e.g. mentioning the files in the man pages for
> Ethereal and Tethereal.
Ok. I'll start looking at the docs and start making the changes.
-Dave