Ethereal-dev: Re: [Ethereal-dev] Improved iSCSI dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 22 Oct 2001 23:24:26 -0700
On Sun, Oct 21, 2001 at 11:23:05AM +0100, Mark Burton wrote:
> One problem that I haven't been able to track down is that if
> desegmentation is enabled and you turn digests on or off ethereal
> throws a SEGV.

Is it still doing that, or did the small patch you later sent:

***************
*** 1212,1217 ****
--- 1212,1219 ----
  	    }
  	    
  	    dissect_iscsi_pdu(tvb, pinfo, tree, offset, opcode, opcode_str, data_segment_len);
+ 	    if(pduLen > available_bytes)
+ 		pduLen = available_bytes;
  	    offset += pduLen;
  	    available_bytes -= pduLen;
  	    ++iSCSIPdusDissected;

fix that?  I couldn't reproduce it with the capture files you've sent.