Ethereal-dev: Re: [Ethereal-dev] patches

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 13 Sep 2001 01:17:53 -0700
On Thu, Sep 06, 2001 at 01:41:14PM +0000, Pia Sahlberg wrote:
> rip.tgz : contains tiny patch to add display filters for all RIP
> protocol fields.

Checked in.

> xot.tgz : tiny patch to add display filters to all XoT protocol
> fields.

Checked in.

> 20010905.tgz : contains small patches for packet-nlm.c

Checked in.

> and packet-stat-notify.c.

I changed it to go back to "STAT-CB" for the short name, and to make
"statnotify" the filter name, as the fields of the protocol have names
that begin with "statnotify.".

The filter name currently can't use "-" to be useful, as the display
filter parser can't handle hyphens in protocol names, but the short name
doesn't have to; is there a need to have the filter name be a
lower-cased version of the short name?  I'm not sure that's the case for
all protocols.

> Also contains patches to add TCP desegmentation support for packet-tcp.c
> and options to desegment NBSS and RPC packets.

Checked in, with additional changes to handle the case where a frame
contains messages that don't run past the end followed by one that does
and where a reassembled chunk has, at the end, a message that runs past
the end of that chunk (because the reassembly was for an earlier
message).

It still doesn't seem to correctly handle a capture I have with
retransmissions; I'll have to look at that.

Do we need to have separate options, for each protocol, to enable
higher-level-PDU reassembly?  That may get clumsy as more protocols add
this capability; I'm inclined to have it controlled only by a TCP flag,
just as IP reassembly is controlled only by an IP flag.