Ethereal-dev: [Ethereal-dev] 3 patches for proto_draw.c, packet-isakmp.c, Makefile.am

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Frank Singleton <frank.singleton@xxxxxxxxxxxx>
Date: Fri, 31 Aug 2001 10:05:12 -0500
Hi,

I get the following errors on my RH7.1 box

I../epan -I/usr/local/include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include
-I/usr/X11R6/include -I/usr/include/pcap -c proto_draw.c
proto_draw.c: In function `find_notebook_page':
proto_draw.c:131: warning: implicit declaration of function `strcmp'
gcc -DHAVE_CONFIG_H -I. -I. -I..   -I.. -I../wiretap -I../epan -I/usr/

gcc -DHAVE_CONFIG_H -I. -I. -I.   -I. -I./wiretap -I./epan -I/usr/local/include -I/usr/include/pcap  -DINET6 -Wall -W
-Wno-unused -g -O2 -I. -I./wiretap -I./epan -I/usr/local/include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2
-I/usr/lib/glib/include -I/usr/X11R6/include -I/usr/include/pcap -c packet-isakmp.c
packet-isakmp.c: In function `dissect_isakmp':
packet-isakmp.c:286: warning: implicit declaration of function `memcmp'
gcc -DHAVE_CONFIG_H -I. -I. -I.   -I. -I./wiretap -I./epan -I/usr/local/include -I/usr/


So, I have included 2 patches to include string.h

twas diffed against 2001-08-31 tarball

patch1.diff - proto_draw.c missing <string.h>
patch2.diff - packet-isakmp.c missing <string.h>

The 3rd patch is to add missing packet-coseventcomm
from #if HAVE_PLUGINS declaration in Makefile.com

patch3.diff - Makefile.am

Cheers / Frank.




-- 
EUS/SV/Z Frank Singleton      ASO Americas BSS
Office : +1 972 583 3251      ECN 800 33251  
Mobile : +1 214 228 0874      Amateur Radio: VK3FCS/KM5WS   
Email : frank.singleton@xxxxxxxxxxxx

Hardware: HP Omnibook 4150 running Redhat Linux 7.1 (2.4.3-12 kernel).
--- proto_draw.c	2001/08/31 14:47:17	1.1
+++ proto_draw.c	2001/08/31 14:47:57	1.2
@@ -1,7 +1,7 @@
 /* proto_draw.c
  * Routines for GTK+ packet display
  *
- * $Id: proto_draw.c,v 1.1 2001/08/31 14:47:17 frank Exp $
+ * $Id: proto_draw.c,v 1.2 2001/08/31 14:47:57 frank Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@xxxxxxxxxxxx>
@@ -44,6 +44,8 @@
 #endif
 
 #include <stdio.h>
+#include <string.h>
+
 #include "main.h"
 #include "packet.h"
 #include "util.h"

--- packet-isakmp.c	2001/08/31 14:48:18	1.1
+++ packet-isakmp.c	2001/08/31 14:48:45	1.2
@@ -3,7 +3,7 @@
  * (ISAKMP) (RFC 2408)
  * Brad Robel-Forrest <brad.robel-forrest@xxxxxxxxxxxxxx>
  *
- * $Id: packet-isakmp.c,v 1.1 2001/08/31 14:48:18 frank Exp $
+ * $Id: packet-isakmp.c,v 1.2 2001/08/31 14:48:45 frank Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@xxxxxxxxxxxx>
@@ -33,6 +33,7 @@
 #endif
 
 #include <stdio.h>
+#include <string.h>
 
 #ifdef HAVE_NETINET_IN_H
 #include <netinet/in.h>

--- Makefile.am	2001/08/31 14:23:38	1.1
+++ Makefile.am	2001/08/31 14:33:16	1.2
@@ -1,7 +1,7 @@
 # Makefile.am
 # Automake file for Ethereal
 #
-# $Id: Makefile.am,v 1.1 2001/08/31 14:23:38 frank Exp $
+# $Id: Makefile.am,v 1.2 2001/08/31 14:33:16 frank Exp $
 #
 # Ethereal - Network traffic analyzer
 # By Gerald Combs <gerald@xxxxxxxxxxxx>
@@ -274,23 +274,27 @@
 plugin_src = \
 	plugins/mgcp/packet-mgcp.c	\
 	plugins/giop/packet-cosnaming.c	\
+	plugins/giop/packet-coseventcomm.c	\
 	plugins/gryphon/packet-gryphon.c 
 
 plugin_static_ldadd = \
 	plugins/mgcp/packet-mgcp-static.o		\
 	plugins/gryphon/packet-gryphon-static.o		\
-	plugins/giop/packet-cosnaming-static.o		
+	plugins/giop/packet-cosnaming-static.o		\
+	plugins/giop/packet-coseventcomm-static.o		
 
 plugin_libs = \
 	plugins/gryphon/gryphon.la \
 	plugins/giop/cosnaming.la \
+	plugins/giop/coseventcomm.la \
 	plugins/mgcp/mgcp.la	
 
 plugin_ldadd = \
 	"-dlopen" self	\
 	"-dlopen" plugins/gryphon/gryphon.la \
 	"-dlopen" plugins/mgcp/mgcp.la \
-	"-dlopen" plugins/giop/cosnaming.la 
+	"-dlopen" plugins/giop/cosnaming.la \
+	"-dlopen" plugins/giop/coseventcomm.la 
 else
 plugin_src =