Ethereal-dev: Re: [Ethereal-dev] new dissector - packet-baby.[ch]

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Frank Singleton <frank.singleton@xxxxxxxxxxxx>
Date: Tue, 28 Aug 2001 07:41:42 -0500
Guy Harris wrote:
> 

> I've checked in a change that moves a bunch of "g_free()" calls as close
> as possible to the allocation, which, if there are no tvbuff references
> between the allocation and the free, obviates the need for a cleanup
> callback.  (I found the calls by auditing the code, which also found
> some places where there *were* no "g_free()" calls, and one place where
> the allocations were happening in a loop but the free was happening
> outside the loop.)

Hi,

Yep, I think it was item 23 on my TODO list at the
top of packet-giop.c to improve/fix the memory 
allocation/deallocation a bit.

I was, however, unaware of the CLEANUP_xxx macros
in exceptions.h ; but not any more :-)

/Frank

-- 
EUS/SV/Z Frank Singleton      ASO Americas BSS
Office : +1 972 583 3251      ECN 800 33251  
Mobile : +1 214 228 0874      Amateur Radio: VK3FCS/KM5WS   
Email : frank.singleton@xxxxxxxxxxxx

Hardware: HP Omnibook 4150 running Redhat Linux 7.1 (2.4.3-12 kernel).