Ethereal-dev: [Ethereal-dev] Tvbuffification of packet-{ipv6,icmpv6}, first take

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Heikki Vatiainen <hessu@xxxxxxxxx>
Date: 20 Apr 2001 01:50:53 +0300
I have now mostly done the tvbuff-related changes to packet-ipv6.c and
packet-icmpv6.c. Mostly means that the ICMPv6 dissector calls
get_dns_name() while dissecting node information response packets and
this function has not been yet tvbuffified, so these two calls are
currently commented out with #if 0/#endif pairs.

Bug fixes include checking for padding after the IPv6 packet,
correcting a display of 8 bit flags field as 32 bit field in Prefix
information option, correcting the order to <TTL><ADDRESS> with node
information, draft-ietf-ipngwg-icmp-name-lookups-07.txt, responses.

Changes to other dissectors are: dissect_ah_old() was removed from
packet-ipsec.c and dissect_ah_header() was made non-static. PIM-SM
register packet decode was changed to call the new method
dissect_ipv6() function.

The updated dissectors were tested with the captures I had/found but I
did not find any e.g. router renumbering ICMPv6 or node information
ICMPv6 packet captures. So if someone can try the patch or provide
some captures for me to test, please keep me posted.

The patch size is almost 70KB so I put it at
http://atm.tut.fi/~hessu/ipv6-tvbuffify.patch

Once packet-dns.c gets upgraded I will upgrade my patch to a more
final version.

-- 
Heikki Vatiainen                  * hessu@xxxxxxxxx
Tampere University of Technology  * Tampere, Finland