[Guy Harris <gharris@xxxxxxxxxxxx>]

On Sun, Apr 08, 2001 at 08:03:49PM +0200, Hannes Gredler wrote:
> From: Hannes Gredler <hannes@xxxxxxxxxxx>
				       ^^^

Juniper's an ISP now? :-)

(Say hi to Dock Williams for me; I think he's still there....)

> first of all there is no OSI support over PPP.
> 
> [hannes@ghostrider ethereal-0.8.16]$ diff ../old/ethereal-0.8.16/ppptypes.h .
> 34a35
> > #define PPP_OSI               0x23
> [hannes@ghostrider ethereal-0.8.16]$ diff ../old/ethereal-0.8.16/packet-osi.c .
> 45a46
> > #include "ppptypes.h"
> 280a282
> [hannes@ghostrider ethereal-0.8.16]$ diff ../old/ethereal-0.8.16/packet-osi.c .
> 45a46
> > #include "ppptypes.h"
> 280a282
> >         dissector_add("ppp.protocol", PPP_OSI, dissect_osi, -1);
> 
> these three fixes should do it.

Actually, that's two fixes - you included the change to "packet-osi.c"
twice (although the first copy appears to be damaged, lacking the second
added line).

> pls let me know what you think of it,

Next time, please submit patches as unified diffs ("diff -u") or context
diffs ("diff -c") - those make it easier to patch a different version of
the source code than the one against which the diffs were made (for
example, the current version in CVS).

> and commit it to the source tree.

Done.