Ethereal-dev: Re: [Ethereal-dev] mgcp plugin patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Thu, 15 Mar 2001 21:22:52 -0800
On Thu, Mar 15, 2001 at 12:06:03AM -0500, Ed Warnicke wrote:
> Please check in this mgcp plugin patch.

	...

> -    if(tvb_lineend < maxoffset){
> -      tempchar = tvb_get_guint8(tvb,tvb_lineend);
> -      tvb_current_len -= tvb_section_length(tvb,tvb_linebegin,tvb_lineend); 
> -      tvb_linebegin = tvb_lineend;
> -    }
> -    else{
> -      tvb_linebegin = tvb_lineend;
> -      break;
> -    }
> -  }

...which removes the only reference to "tvb_section_length()", but it's
still defined, which causes a warning

	packet-mgcp.c:1247: warning: `tvb_section_length' defined but
	    not used

when compiled with GCC.

Should "tvb_section_length()" be removed?