Ethereal-dev: Re: [Ethereal-dev] New feature for ethereal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 12 Feb 2001 01:36:23 -0800
On Thu, Jan 18, 2001 at 06:33:12PM -0800, David Hampton wrote:

	...

> +/*
> + * This routine is called when the user clicks the "OK" button in the
> + * "Decode As..." dialog window and a 'simple' page is foremost.
> + * This routine takes care of making any changes requested to the
> + * dissector tables.  This routine is currently used for IP and
> + * Ethertypes.  Any 'single change' notebook page can use this
> + * routine.
> + *
> + * @param notebook_pg A pointer to the "network" notebook page.
> + */
> +static void
> +decode_simple (GtkWidget *notebook_pg)
> +{

	...

> +    string = g_malloc(1024);
> +    table_name = gtk_object_get_data(GTK_OBJECT(notebook_pg), E_PAGE_TABLE);
> +    value = GPOINTER_TO_INT(gtk_object_get_data(GTK_OBJECT(notebook_pg),
> +						E_PAGE_VALUE));
> +    decode_change_one_dissector(string, table_name, value, clist);
> +    simple_dialog(ESD_TYPE_INFO, NULL, string);
> +    g_free(string);
> +}

Is there a need to pop up the "I'm now dissecting XXX as YYY" dialog
box?  It seems like just another dialog box to be dismissed - if that's
what the user wanted to happen, I'm not sure it tells them anything they
didn't already know, and if that's not what the user wanted to happen,
why did they click "OK" in the dialog box?