Ethereal-dev: Re: [Ethereal-dev] Patch for x25 over TCP dissector (RFC 1613)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Sat, 16 Dec 2000 23:39:19 -0800
On Sat, Dec 16, 2000 at 10:26:49PM +0200, Paul Ionescu wrote:
> I have attached to this email an initial xot dissector (x25 over TCP as
> in RFC 1613) and a very limited xot packet capture.
> Please commit and update the Makefile.am and Makefile.nmake for it. (I
> do not have access to cvs right now)

Done.

Note that:

> /* Actualy, you can never see the COL_INFO for XOT because of the mandatory X25 layer after it.
> 
> 
>   if (check_col(pinfo->fd, COL_INFO)) 
>      col_add_fstr(pinfo->fd, COL_INFO, "XOT Version = %d, size = %d",version,len );
> */  	        

you *can*, in fact, see that COL_INFO, if the X.25 dissector has been
disabled, so I un-commented that code (and moved the fetch of "version"
and "len" before it).