Ethereal-dev: Re: [Ethereal-dev] MGCP plugin

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Gilbert_Ramirez@xxxxxxxxxx
Date: Wed, 8 Nov 2000 16:27:20 -0600
I assume that in this section of packet-mgcp.c:

static gint tvb_crlf_strip(tvbuff_t *tvb, gint offset, gint maxlength){
  gint returnvalue;
  guint8 tempchar;

  for(returnvalue = maxlength;
      ( (returnvalue >= 0 ) && (
        ((tempchar = tvb_get_guint8(tvb,offset + returnvalue) ) == 'r')  ||
        (tempchar == '\n')));
      returnvalue--);
  return ( returnvalue );
}


you meant to compare the return value of tvb_get_guint() against '\r' instead of 'r'. ???

--gilbert