Ethereal-dev: Re: [Ethereal-dev] Enhancements to packet-giop.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 6 Nov 2000 23:49:03 -0800
On Mon, Nov 06, 2000 at 08:23:41PM -0500, Craig Rodrigues wrote:
> There is a lot here that is very useful, though.
> I hope this code makes it into Ethereal......

Checked in.

I made "stream_is_big_endian" an argument to various dissection
routines, rather than a global (a bit cleaner - dissectors typically
don't have to be reentrant, but it's probably not a bad idea to make
them reentrant), made the "const" declarations of numbers static, made
all the routines other than the register and register-handoff routines
static (none of them are referred to outside "packet-giop.c"), and just
made it return FALSE if "proto_is_protocol_enabled()" returns FALSE (it
shouldn't dissect the packet as raw data, it should just return FALSE to
let other dissectors look at it).