Ethereal-dev: [ethereal-dev] proto_tree_add_ipv4

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Michael Tuxen <Michael.Tuexen@xxxxxxxxxxxxx>
Date: Fri, 7 Jul 2000 12:55:45 +0200
Dear all,
the last parameter of the proto_tree_add_ipv4 function is the guint32
address in network byte order. In the corresponding IPv6 function it is a
pointer.
When dealing with tvbuffs I think it would be a goot idea to change
proto_tree_add_ipv4 so that the last paramter is also a pointer. Then
both functions are similiar and I don't have
to use first a tvb_memcpy call to get the ip address in network byte
order and than to call
proto_tree_add_ipv4. I could only call proto_tree_add_ipv4 and use
tvb_get_ptr for the last argument.
Any comments?
Best regards
Michael

--
e-mail: Michael.Tuexen@xxxxxxxxxxxxx