Ethereal-dev: Re: [ethereal-dev] Patch to remove pseudo-header from "frame_data" structure

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Thu, 18 May 2000 02:08:57 -0700
On Tue, May 02, 2000 at 12:01:31PM -0500, Gilbert Ramirez wrote:
> > This patch removes the pseudo-header from the "frame_data" structure, to
> > reduce the memory use for those structures (which is probably
> > significant for very large capture files).
> 
> Great!

Checked in.

> BTW,
> 
> I noticed the addition of the "pseudo_header" argument to
> dissect_packet() and to a few other dissectors. Once I start merging in
> my changes for "tvbuff", I'm going to provide a new struct called "dissection"
> which contains information that is relevant for all dissectors of a single
> frame but is not needed in frame_data. This includes:
> 
> 	pi
> 	cinfo (moved from frame_data)
> 	pseudo_header (your new addition)
> 
> The call to a dissector will then look like:
> 
> 	dissect_packet(tvbuff, tree, dissection)
> 
> I might put 'tree' into dissection as well.

Good idea.

You might want to put the "proto_tree_is_visible" flag there as well, so
it's not a global variable.