Ethereal-dev: RE: [ethereal-dev] Checked in support for MPLS

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Jeff Foster <jfoste@xxxxxxxxxxxx>
Date: Fri, 10 Mar 2000 08:49:29 -0600
> I shall add a note about this to the "README.developer" file (which
> already has a comment noting that C++-style comments should not be used,
> for example, as some C compilers reject them).

Guy,

Please note that I moved the C++ comments note to a '1. Code Style.'  

Maybe 'Code Style' to the wrong section header;  a more generic
'Coding Rules'  may fit better.

A section on data types should be added. The code has glib gXXX
types in some places and 'C' style (int,char,..) in other places.

Should the macro style (upper case with underbars) be added to the
'Name convention' section?


Jeff Foster
jfoste@xxxxxxxxxxxx