Ethereal-dev: Re: [ethereal-dev] Ethereal Win32 libpcap patch.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Wed, 2 Feb 2000 22:34:51 -0800
> Attached is my patch. let me know if there are any problems.

I also checked in the change to the top-level "file.c".

However, that change raises another question.  The code in question is
reading the capture file to be saved and writing to the saved file; your
change makes it open the input file in binary, but the output file is
being opened with

	creat(fname, 0644)

On Win32, does that open in ASCII mode, or binary?  If it's in ASCII
mode, that would presumably have to be changed to

	open(fname, O_CREAT|O_TRUNC|O_WRONLY|O_BINARY, 0644)

in order to write the capture file in binary.