Ethereal-cvs: [Ethereal-cvs] rev 15808: /trunk/epan/dissectors/: packet-lldp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxx
Date: Thu, 15 Sep 2005 04:08:55 GMT
User: guy
Date: 2005/09/14 11:08 PM

Log:
 We already define ETHERTYPE_LLDP in "etypes.h" - use that, don't define
 our own.
 
 Get rid of MAC_to_str() - ether_to_str() suffices.
 
 Don't copy to on-the-stack fixed-size string buffers, just save the
 results of various formatting calls as pointers.
 
 Use tvb_format_text() to get displayable versions of text strings.
 
 Use tvb_get_ipv4() and tvb_get_ipv6().
 
 Don't put an item into the protocol tree as text and then put in a
 hidden item that, if unhidden, would display the same or almost exactly
 the same; just put the item into the tree unhidden.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +593 -658  packet-lldp.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=15808&view=rev