Ethereal-cvs: [Ethereal-cvs] rev 15239: /trunk/epan/dissectors/: packet-ms-mms.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxx
Date: Sat, 06 Aug 2005 09:23:30 GMT
User: guy
Date: 2005/08/06 04:23 AM

Log:
 Don't assign "" to a string that's only used after it's assigned to.
 
 "tvb_fake_unicode()" never returns a null pointer, so there's no need to
 check for it; there's also no need to check that it's not an empty
 string before freeing it, as it's always assigned a g_malloc()ed string.
 
 It also takes as an argument the number of Unicode characters in the
 string, not the number of bytes in the string.
 
 Use "format_text()" when adding a string to the Info column, in case
 it has non-printable characters.
 
 Don't use "proto_tree_add_string_format()" if you don't have to.

Directory: /trunk/epan/dissectors/
  Changes    Path               Action
  +50 -71    packet-ms-mms.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=15239&view=rev